fix: Update swizzling of waitForQuiescenceIncludingAnimationsIdle: API for Xcode16-beta5 #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I for Xcode16-beta5
KazuCocoa
approved these changes
Aug 9, 2024
| - (void)waitForQuiescenceIncludingAnimationsIdle:(BOOL)arg1; | ||
| // Since Xcode16-beta5 | ||
| - (void)waitForQuiescenceIncludingAnimationsIdle:(BOOL)arg1 isPreEvent:(BOOL)arg2; |
There was a problem hiding this comment.
It looks like here has new ones:
- (void)waitForQuiescenceIncludingAnimationsIdle:(_Bool)idle isPreEvent:(_Bool)event;
- (void)waitForQuiescenceIncludingAnimationsIdle:(_Bool)idle usingActivity:(_Bool)activity isPreEvent:(_Bool)event;
not sure the using activity one, but I think lg overall
There was a problem hiding this comment.
I've tested it locally with simulator and it seems ok. Need more feedback to confirm the other method is called independently as I can only see it being invoked from - (void)waitForQuiescenceIncludingAnimationsIdle:(_Bool)idle isPreEvent:(_Bool)event; one
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
## [8.9.1](v8.9.0...v8.9.1) (2024-08-09) ### Bug Fixes * Update swizzling of waitForQuiescenceIncludingAnimationsIdle: API for Xcode16-beta5 ([#935](#935)) ([2ccc436](2ccc436))
|
🎉 This issue has been resolved in version 8.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses appium/appium#20239 (comment)