Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Wait for the browser to load before continuing the session #930

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions WebDriverAgentLib/Commands/FBSessionCommands.m
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,10 @@ + (NSArray *)routes
if (nil != errorResponse) {
NSLog(@"Was not able to open the default URL %@ in Safari", healthEndpoint);
}
NSLog(@"Waiting for %@ to finish loading", healthEndpoint);
// To avoid the race condition while starting the remote debugger
[app fb_waitUntilStableWithTimeout:15.0];
NSLog(@"Load completed: %@", healthEndpoint);
}
}
if (!app.running) {
Expand Down
Loading