Update lint rules

appium · Aug 23, 2023 · d3388a8 · d3388a8
1 parent 322f501
commit d3388a8
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 5 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -9,7 +9,14 @@
       }
     },
     {
-      "files": "Scripts/**/*",
+      "files": "Scripts/**/*.js",
+      "parserOptions": {"sourceType": "script"},
+      "rules": {
+        "@typescript-eslint/no-var-requires": "off"
+      }
+    },
+    {
+      "files": "ci-jobs/scripts/*.js",
       "parserOptions": {"sourceType": "script"},
       "rules": {
         "@typescript-eslint/no-var-requires": "off"

diff --git a/lib/check-dependencies.js b/lib/check-dependencies.js
@@ -27,10 +27,9 @@ async function checkForDependencies () {
   return false;
 }
 
-async function bundleWDASim (xcodebuild, opts = {}) {
+async function bundleWDASim (xcodebuild) {
   if (xcodebuild && !_.isFunction(xcodebuild.retrieveDerivedDataPath)) {
     xcodebuild = new XcodeBuild('', {});
-    opts = xcodebuild;
   }
 
   const derivedDataPath = await xcodebuild.retrieveDerivedDataPath();

diff --git a/lib/xcodebuild.js b/lib/xcodebuild.js
@@ -350,10 +350,10 @@ class XcodeBuild {
             logFile.on('line', (line) => {
               xcodeLog.error(line);
             });
-            await new B((resolve) => {
+            await new B((_resolve) => {
               logFile.once('close', () => {
                 logFile.removeAllListeners();
-                resolve();
+                _resolve();
               });
             });
           } catch (err) {

diff --git a/package.json b/package.json
@@ -57,6 +57,7 @@
   "devDependencies": {
     "@appium/eslint-config-appium": "^8.0.4",
     "@appium/eslint-config-appium-ts": "^0.3.1",
+    "@appium/test-support": "^3.0.0",
     "@appium/tsconfig": "^0.3.0",
     "@appium/types": "^0.13.2",
     "@semantic-release/changelog": "^6.0.1",