make carriage returns behave normally #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OK so essentially we noticed a behaviour where carriage returns were behaving really abnormally, and it was common to see appium enter something like this
@someon
ehas a cat
rather than
@Someone
has a cat
The extra letter would drop between lines. It didn't happen too consistently etc, but we eventually worked out what it was, and changing the carriage return to be ascii printable seems to have fixed the error.
Was tested as still happily typing Emoji and other unicode characters so I don't think it will cause anyone else problems, but feel free to take it or leave it - wanted to add a PR here to give back, as we rely on Appium a lot and I'm more than happy to support it however we can!