Skip to content

Commit

Permalink
Merge pull request #1238 from appirio-tech/f2f-skill_picker-by_shubhe…
Browse files Browse the repository at this point in the history
…ndus

Done button made active on page dirty instead of only communities
  • Loading branch information
ajefts authored Oct 17, 2017
2 parents e97535f + 6fb6527 commit 83f454d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/skill-picker/skill-picker.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ import _ from 'lodash'
}
promises.push(ProfileService.updateUserSkills(vm.username, data))
}
logger.debug('isCommunitiesDirty: ' + isCommunitiesDirty())

if (isCommunitiesDirty()) {
for(var communityName in vm.communities) {
var community = vm.communities[communityName]
Expand Down
2 changes: 1 addition & 1 deletion app/skill-picker/skill-picker.jade
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@
type="button",
tc-busy-button, tc-busy-when="vm.saving",
ng-click="vm.submitSkills()",
ng-disabled="vm.disableDoneButton || !vm.isCommunitySelected()") Done
ng-disabled="vm.disableDoneButton || !vm.isPageDirty()") Done

0 comments on commit 83f454d

Please sign in to comment.