Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error on "nameResolution.dnsForwarding.siteIpv4/siteIpv6 is not a valid IP address." #340

Merged
merged 2 commits into from
Nov 28, 2023
Merged

Fix error on "nameResolution.dnsForwarding.siteIpv4/siteIpv6 is not a valid IP address." #340

merged 2 commits into from
Nov 28, 2023

Conversation

mandopaloooza
Copy link
Contributor

  • Add explicit check for empty string on site.name_resolution.dns_forwarding.site_ipv4/v6
  • Throw error if neither site_ipv4 or site_ipv6 is provided in sites.name_resolution.dns_forwarding

@mandopaloooza mandopaloooza merged commit 547b910 into master Nov 28, 2023
2 checks passed
@mandopaloooza mandopaloooza deleted the dnsforwarding-siteip branch November 28, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomascellerier thomascellerier thomascellerier approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mandopaloooza @thomascellerier