Skip to content
This repository has been archived by the owner on Jul 27, 2023. It is now read-only.

Fix Rails 5.1; use before_action instead of before_filter #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

scottbartell
Copy link

before_filter is deprecated and was removed in Rails 5.1.

Note: I believe that before_action is supported in Rails 4 but not in Rails 3. IMO, if this gem does currently work in Rails 3 (I have no idea if it does), dropping support might not be too bad of an idea given that Rails 3.x has been officially unsupported since June 2016.

@chrishough
Copy link

Plus 💯

I am getting the following error because of this...

rake aborted!
NoMethodError: undefined method `before_filter' for EslintController:Class
Did you mean?  before_action
(See full trace by running task with --trace)```

@DLvalentine
Copy link

Hey all, not sure what the timeline is for this repo, but I have forked it and included this PR on the repo located here: https://github.com/DLvalentine/eslint-rails-ee

Cheers

@aadill77
Copy link

Hey @jonkessler let's get this PR merged. We are getting error in Rails version upgrade.

@jonkessler
Copy link
Contributor

@aadill77, first off, I don’t work for the company anymore so I can’t merge this. Second off, this is open source. You’re getting this work for free and you don’t get to demand that people do work for you.

Maybe @amutz can help get this merged.

@DLvalentine
Copy link

FWIW @aadill77 , I have a fork here https://github.com/dlvalentine/eslint-rails-ee that did merge in this PR

@aadill77
Copy link

@jonkessler sorry for that rude tone. Didn't realize it until I read it again myself. My bad!

@aadill77
Copy link

@DLvalentine Thanks for your help.

@JerrodCarpenter
Copy link

I'm seeing this as well, any timeline on when this will be merged?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants