This repository has been archived by the owner on Jul 27, 2023. It is now read-only.
Add compatibility with Ruby 2.0 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkessler
reviewed
May 7, 2017
lib/eslint-rails/config.rb
Outdated
| @@ -10,7 +10,7 @@ def self.read(force_default: false) | |||
| CONFIG_PATH = 'config/eslint.json' | |||
| private_constant :CONFIG_PATH | |||
|
|
|||
| def initialize(force_default:) | |||
| def initialize(force_default: raise(ArgumentError, 'force_default is required')) | |||
There was a problem hiding this comment.
I'd prefer it if instead of doing this inline in the declaration, we make this force_default: nil and then raise on the first line if it's nil.
|
Left one comment. Just curious.. what issues are preventing you from upgrading from 2.0? I don't recall any serious issues when we upgraded our main app, which is many hundreds of thousands of lines of code. |
bbonamin
force-pushed
the
ruby-2.0-compatibility
branch
from
54d81d0 to
fcdc0b3
Compare
|
We don't really have any specific issues that prevent upgrading other than allocating the resources for a few dozen ruby applications. I've used newer rubies in other projects without issues either, just improvements! Thanks. |
|
For sure. Definitely worthwhile for the performance improvements in our experience. Thanks for the pull! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, let me express my gratitude for this gem.
I've been trying to add a javascript linter to a project I'm working on so we can have some standards, and by far eslint-rails has been the best suited.
Now, for this project, we need compatibility with Ruby 2.0 (yeah yeah, I know it's not receiving fixes or patches anymore, but we can't upgrade yet.)
The gemspec of eslint-rails doesn't specify a minimum ruby version, but if you try to use the gem with < 2.1, it breaks because of the required keyword arguments that were introduced in 2.1.
This minor change makes the gem compatible with Ruby 2.0 and ensures it's specified on the gemspec.
Thanks!