-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate Handoff Protocol #140
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions, and add warnings to previous or uncertain transaction types. Also implements payment reference tracking, though this isn't used as of now. Changes to various handoff-related localization messages have also been made.
…g with loading initial state.
… to 3s, increase handoff error to 6s.
Currently in the process of revising the protocol and making adjustments, will submit a new PR at a later date when everything's been updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototype integration of the Handoff Payment protocol.
See relevant forum thread for more info (slightly outdated): https://forum.nano.org/t/unique-payment-id-via-payment-protocol/1253
Changelog
nanohandoff
URIhandoff
parameter tonano
URI (Address
)Payments
table to local database which stores information about outgoing transactions/blocks.handoffInvalid
- Payment request cannot be parsed or is incompatible with the wallethandoffPaymentFailed
- Payment couldn't be made (possibly followed by details)handoffPaymentAlreadyComplete
- Payment has already been madehandoffExpired
- Payment has expiredusingHandoff
- Notice on the confirmation sheet showing the handoff protocol will be usedpaymentCannotReplay
- When a payment cannot be repeated (left-swiped)sendDestinationWarning
- Warning when replaying (left-swipe) unrecognized paymentsImplementation notes
work_generate
RPC is not publicly exposed)https
channel is currently supportedOther notes
intl_translation
dependency and making a small change to thebuild.gradle
. The patches to fix these issues have not been included in this PR (I assume it's a problem with my local env)