-
Notifications
You must be signed in to change notification settings - Fork 146
Conversation
One thing about this I was uncertain about was that I left all of the copyright attributions at the top of the copied in files as |
woah, thanks! I guess we can cut a bit more, namely the whole protobuf dependency. Looking at what this type implements now it seems a bit too much:
Some of the above are redundant, reducing to:
which all reside in
This Quantity type is quite involved, using fixed point arithmetic, so I would leave all those tests. |
This commit removes k8s.io/kubernetes as a dependency. The one part of the repo that we were using, k8s.io/kubernetes/pkg/api/resource, has been copied to schema/types/resource, and very minimally modified to work in its new location. A README.md has been added to this new location describing where the files came from. This was necessary to avoid a cyclic dependency with the kubernetes repo.
Removed the files you requested |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the fast solution of the issue! 👍 |
No problem! Now we should just need a new release to use on the k8s side of this. I'll leave that to someone else to take care of... |
This commit removes k8s.io/kubernetes as a dependency. The one part of
the repo that we were using, k8s.io/kubernetes/pkg/api/resource, has
been copied to schema/types/resource, and very minimally modified to
work in its new location. A README.md has been added to this new
location describing where the files came from.
This was necessary to avoid a cyclic dependency with the kubernetes
repo.
Fixes #683.