Update appc data structures for CRI #656
Conversation
|
For reference, this PR goes to a new |
| Isolators []types.Isolator `json:"isolators"` | ||
| Annotations types.Annotations `json:"annotations"` | ||
| Ports []types.ExposedPort `json:"ports"` | ||
| CRIAnnotations types.CRIAnnotations `json:"criAnnotations,omitempty"` |
There was a problem hiding this comment.
@squeed CRIAnnotation and CRILabels sounds too specific for CRI? Why not just using the old Annotations and changing the type of the Key from ACIdentifier to string?
Both Label or Annotation can be muxed into annotations with prefixes.
There was a problem hiding this comment.
@yifan-gu I thought about that, but the appc spec already defines some app annotations with special parsing rules, e.g. 'created'.
If we're going to add a type that allow arbitrary user-specified Kubernetes labels, we can't go adding more meaning to them.
There was a problem hiding this comment.
This seems to be inline with previous discussion about this at rkt/rkt#3010 (comment)
|
We need to make progress on other parts of the CRI push, so I'm merging this, but we don't need to stop the discussion. |
|
|
||
| import "fmt" | ||
|
|
||
| type CRILabels map[ACIdentifier]string |
@yifan-gu @lucab @s-urbaniak I also updated the appc spec for annotations, along with port forwards. Take a look and we can update glide to pull from appc/spec's CRI branch.