This repository has been archived by the owner on Aug 14, 2020. It is now read-only.
ace validator: fix app annotations validation. #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // with PodManifest overrides | ||
| expectedAnnots := app.Annotations | ||
| expectedAnnots := img.Annotations | ||
| a := pm.Apps.Get(app.Name) |
There was a problem hiding this comment.
Great catch, although this raises another point of confusion for me - isn't this line just the same as app??
There was a problem hiding this comment.
@jonboulle you're right! I removed that code part.
The runtimeApp annotations were merged over themself and not over the image manifest annotations.
sgotti
force-pushed
the
fix_ace_validator_validate_app_annotations
branch
from
d183e7b
to
2cd8535
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtimeApp annotations were merged over themself and not over the image
manifest annotations.