tests: Added tests for auth handler plugin #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhinavraj23
changed the title
jeet-parekh
reviewed
Sep 24, 2019
|
@jeet-parekh Actually I was doing it, it should be saved in the .publickey index, I have made the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Added tests for handlers of auth and completed the leftover methods in middleware tests
What should your reviewer look out for in this PR?
Added tests for methods in
handlers.goof auth folder in handler_test.goDo you need help or clarification on anything?
Yes, want to know if I have used the right methodology for testing the publicKey
Which issue(s) does this PR fix?
#16 #17