Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add several instance types to the max_conns mapping #28

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

steveteahan
Copy link
Contributor

Just trying to get these added to clear some alerts for now, but I'm still wondering if there's a better way to handle this. These values could be calculated with the memory of the instances.

Copy link

@geoberle geoberle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting the noise out of the way is a good thing so extending this workaround for now looks ok to me

@steveteahan steveteahan merged commit 8e601c1 into app-sre:master Mar 28, 2022
@steveteahan steveteahan deleted the add-missing-rds-max-conns branch March 28, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants