Update package clean-css, because we had problems with shorthand #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 😄 |
|
@stuartromanek @jsumnersmith @kyjoya @suhmantha1 would y'all please take a look at this pull request and make sure it doesn't cause any CSS problems (mostly looking for flat-out errors here) with a few of our fancier websites when Apostrophe is using this newer version of the cleancss package? I can see that the older version is missing support for a valid CSS construct, and I'd like to accept this pull request, but we need some due diligence here first. Thanks! |
|
Closing because 0.5.x is in maintenance mode. Please use 2.x for new development. It uses a much newer release of clean-css. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a problem with the
clean-csswith version1.x, so i updated the package. Please review and check if you find some problems. Thx!Example:
was this after the minify-process: