-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Querystring filter #24
Querystring filter #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thank you. A couple minor notes, and I'd appreciate an entry in the Changelog section of README.md.
If you're too busy let me know though, these are good changes and I don't mind doing cleanup if needed.
Code updated and changes pushed, should be all good. |
Thanks for the contribution! This should come out in our next release cycle (2 weeks). |
Is there new functionality here that should be covered in the README? |
Oops, that's embarrassing - I didn't push up the README edit. Tom, do you want/need me to do a new pull request for that? "By default a redirect includes any query string on incoming requests when matching for redirection. You can toggle the 'Ignore query string when matching.' option to ignore query strings on requests and only match on the base URL path." |
D'oh, I missed it too! Would you mind Shaun? Thanks.
…On Wed, Feb 10, 2021 at 12:08 PM Shaun Hurley ***@***.***> wrote:
Oops, that's embarrassing - I didn't push up the README edit. Tom, do you
want/need me to do a new pull request for that?
"By default a redirect includes any query string on incoming requests when
matching for redirection. You can toggle the 'Ignore query string when
matching.' option to ignore query strings on requests and only match on the
base URL path."
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAH27OTTXN5UVRH4JBQO6TS6K4QLANCNFSM4XL5G3BA>
.
--
THOMAS BOUTELL | CHIEF TECHNOLOGY OFFICER
APOSTROPHECMS | apostrophecms.com | he/him/his
|
Tom,
Working optional querystring filter code as discussed in issue #23
Added a new field to the redirect definition called
ignoreQUerystring
and the rest of it is pretty much in line with your suggestions.Cheers,
Shaun