Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querystring filter #24

Merged
merged 3 commits into from
Feb 10, 2021
Merged

Querystring filter #24

merged 3 commits into from
Feb 10, 2021

Conversation

shaunhurley
Copy link
Contributor

Tom,

Working optional querystring filter code as discussed in issue #23

Added a new field to the redirect definition called ignoreQUerystring and the rest of it is pretty much in line with your suggestions.

Cheers,

Shaun

Copy link
Contributor

@boutell boutell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thank you. A couple minor notes, and I'd appreciate an entry in the Changelog section of README.md.

If you're too busy let me know though, these are good changes and I don't mind doing cleanup if needed.

index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
index.js Outdated Show resolved Hide resolved
@shaunhurley
Copy link
Contributor Author

Code updated and changes pushed, should be all good.

@boutell boutell merged commit d5f67e0 into apostrophecms-legacy:master Feb 10, 2021
@boutell
Copy link
Contributor

boutell commented Feb 10, 2021

Thanks for the contribution! This should come out in our next release cycle (2 weeks).

@abea
Copy link

abea commented Feb 10, 2021

Is there new functionality here that should be covered in the README?

@shaunhurley
Copy link
Contributor Author

Oops, that's embarrassing - I didn't push up the README edit. Tom, do you want/need me to do a new pull request for that?

"By default a redirect includes any query string on incoming requests when matching for redirection. You can toggle the 'Ignore query string when matching.' option to ignore query strings on requests and only match on the base URL path."

@boutell
Copy link
Contributor

boutell commented Feb 10, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants