Adds analytics and user conf #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any red flags yet? |
|
We're not merging into master just yet, to not load this one PR up with too much that should be deployed in that release. |
boutell
requested changes
May 21, 2020
CHANGELOG.md
Outdated
| command. | ||
| * Adds the opt-in option to send basic, anonymous usage information to the | ||
| maintainers. This involves the CLI creating a configuration file on the user's | ||
| machine to save the user's approval response and a unique ID. |
|
I wanted to say, since I raised concerns and it might not be otherwise clear: this is very good work. |
boutell
previously approved these changes
May 27, 2020
|
@localghost443 See 8ff56fb. Are there any blockers to getting this merged for the next release? |
|
Another example of CLI usage tracking: https://github.com/nuxt/telemetry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some basic usage tracking, with support of added user configuration.
Also closes #25 and #35
postuninstallscript to remove the config file.