Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency (winston) breaks on node 14.x #35

Closed
gitbugr opened this issue Jun 19, 2020 · 3 comments · Fixed by #39
Closed

Dependency (winston) breaks on node 14.x #35

gitbugr opened this issue Jun 19, 2020 · 3 comments · Fixed by #39
Assignees
Labels

Comments

@gitbugr
Copy link

gitbugr commented Jun 19, 2020

Winston 2.x doesn't work with node 14.x. and thus breaks this tool.

winstonjs/winston#1797

 Apostrophe  create-project  Failed
(node:75963) Warning: Accessing non-existent property 'padLevels' of module exports inside circular dependency
    at emitCircularRequireWarning (internal/modules/cjs/loader.js:823:11)
    at Object.get (internal/modules/cjs/loader.js:837:5)
    at Object.exports.setLevels (/Users/kyron/.nvm/versions/node/v14.4.0/lib/node_modules/apostrophe-cli/node_modules/winston/lib/winston/common.js:32:14)
    at Object.<anonymous> (/Users/kyron/.nvm/versions/node/v14.4.0/lib/node_modules/apostrophe-cli/node_modules/winston/lib/winston.js:83:8)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Module.require (internal/modules/cjs/loader.js:1089:19)
    at require (internal/modules/cjs/helpers.js:73:18)

For now I've downgraded my node version to 13.x and it's working fine.

@gitbugr gitbugr added the bug label Jun 19, 2020
@DABH
Copy link

DABH commented Jun 22, 2020

winston 2.4.5 has been released which should resolve this issue, though we encourage migrating to Winston@3 which is maintained and is tested with latest Node versions.

@abea
Copy link
Contributor

abea commented Jun 24, 2020

Thanks for flagging this. We have a 3.x version that's inching closer to being approved that updates prompt, getting rid of winston entirely. https://github.com/apostrophecms/apostrophe-cli/pull/32/files

It might be possible to update the current version's prompt dependency as well, which would be a great contribution.

@abea
Copy link
Contributor

abea commented Dec 9, 2020

The 3.x version stalled out while we work on Apostrophe 3.x, so we're fixing this. Sorry for the delay!

@abea abea self-assigned this Dec 9, 2020
@abea abea closed this as completed in #39 Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants