Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to uv (attempt 2) #82

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Switching to uv (attempt 2) #82

merged 6 commits into from
Nov 13, 2024

Conversation

apoorvkh
Copy link
Owner

uv has better support for installing PyTorch, since 0.5.0 (astral-sh/uv#8797)

I tried to switch from pixi to uv earlier (#75) but ran into several issues. But it works now!

Simply uv sync to build the virtual environment, then source .venv/bin/activate to activate.

Switched the CI pipeline to UV as well.

@apoorvkh apoorvkh mentioned this pull request Nov 12, 2024
@apoorvkh apoorvkh linked an issue Nov 12, 2024 that may be closed by this pull request
@pmcurtin
Copy link
Collaborator

I'll also check it works locally for me

@apoorvkh
Copy link
Owner Author

I think you should only have one of [project.urls] (line 32 above) or urls = { ... } (line 14 that you are mentioning) in this file. Does your repo have unresolved merge conflicts (in pyproject.toml)?

@apoorvkh
Copy link
Owner Author

I only see one instance of urls here: https://github.com/apoorvkh/torchrunx/blob/uv-v2/pyproject.toml

@pmcurtin
Copy link
Collaborator

Yeah I was simply on the wrong branch lmao, there's no issue

Copy link
Collaborator

@pmcurtin pmcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and works fine!

@pmcurtin pmcurtin merged commit 749a321 into main Nov 13, 2024
27 checks passed
@pmcurtin pmcurtin deleted the uv-v2 branch November 13, 2024 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to uv?
2 participants