Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move user requested apt-get packages to be installed into starter.ini #198

Closed
apolopena opened this issue Feb 6, 2022 · 0 comments
Closed
Assignees
Labels
important passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main task tasks not related to bugs or enhancements

Comments

@apolopena
Copy link
Owner

apolopena commented Feb 6, 2022

Currently packages the user wants downloaded during the image build step are in set as a string in .gp/bash/install-project-packages.sh but that string should really be parsed from starter.ini so .gp/bash/install-project-packages.sh can remain untouched since there is core logic in that files that could change in a future release.

Add a new section to starter.ini for packages that should be installed during the docker image build phase. The valid value will be a space delimited string of valid apt-get packages with no trailing or leading space.

[apt-get]
packages=
@apolopena apolopena added task tasks not related to bugs or enhancements important labels Feb 6, 2022
@apolopena apolopena added this to the Next Release 🔮 milestone Feb 6, 2022
@apolopena apolopena self-assigned this Feb 6, 2022
apolopena added a commit that referenced this issue Feb 8, 2022
apolopena added a commit that referenced this issue Feb 8, 2022
apolopena added a commit that referenced this issue Feb 8, 2022
apolopena added a commit that referenced this issue Feb 8, 2022
apolopena added a commit that referenced this issue Feb 8, 2022
@apolopena apolopena added passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
important passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main task tasks not related to bugs or enhancements
Projects
None yet
Development

No branches or pull requests

1 participant