Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings.json, php-conf.php should only be parsed when the project is bootstrapped #196

Closed
apolopena opened this issue Feb 2, 2022 · 2 comments
Closed

settings.json, php-conf.php should only be parsed when the project is bootstrapped #196

apolopena opened this issue Feb 2, 2022 · 2 comments
Assignees
@apolopena
Labels
bug Something isn't working important passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Milestone
v1.5 release 🚀

Comments

@apolopena
Copy link
Owner

Describe the bug

.vscode/settings.json and .gp/conf/php-fpm/php-fpm.conf will get overwritten once they are bootstrapped (built for the first time).

Screenshots

Steps to reproduce

  1. Create a new repo from this repo
  2. Create a new Gitpod workspace from the new repo
  3. Make some changes in .vscode/settings.json and .gp/conf/php-fpm/php-fpm.conf
  4. Save all changes to the remote repo
  5. Build a new workspace from the new repo

Observe that the changes made to .vscode/settings.json and .gp/conf/php-fpm/php-fpm.conf in step 3 are gone.

Expected behavior

Chnage made to .vscode/settings.json and .gp/conf/php-fpm/php-fpm.conf after a project is bootstrapped should remain

Additional information
@apolopena apolopena added bug Something isn't working important labels Feb 2, 2022
@apolopena apolopena self-assigned this Feb 2, 2022
@apolopena apolopena added this to the Next Release 🔮 milestone Feb 3, 2022
@strausmann
Copy link
Contributor

Each time you load the project in with a GitPod workspace, the two lines are added again.

image

@apolopena
Copy link
Owner Author

I will get a patch release out for this ASAP.

@apolopena apolopena added the in-development Bug or feature is currently being worked on label Feb 6, 2022
apolopena added a commit that referenced this issue Feb 6, 2022
@apolopena
🐛 FIX: #196
2e79e0b
apolopena added a commit that referenced this issue Feb 6, 2022
@apolopena
🤖 TEST: #196
ce573c6
apolopena added a commit that referenced this issue Feb 7, 2022
@apolopena
🐛 FIX: #196
006b40f
@apolopena apolopena added passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-development Bug or feature is currently being worked on labels Feb 8, 2022
apolopena added a commit that referenced this issue Feb 8, 2022
@apolopena
🐛 FIX: #196
834d3d7
@apolopena apolopena mentioned this issue Feb 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apolopena apolopena

Labels
bug Something isn't working important passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Milestone
v1.5 release 🚀
Development

No branches or pull requests
2 participants
@apolopena @strausmann