Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make react example presets use their own package.json #185

Closed
apolopena opened this issue Jan 26, 2022 · 1 comment
Closed

Make react example presets use their own package.json #185

apolopena opened this issue Jan 26, 2022 · 1 comment
Assignees
@apolopena
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Milestone
v1.4 release 🚀

Comments

@apolopena
Copy link
Owner

Describe the bug

The react preset example repositories do not use their own package.json and since gls (gitpod-laravel-starter) uses 8.* this means that any of the dev dependencies for the project can be bumped up at any time. This can break all kinds of things.
A perfect example of this being a problem is #184

Screenshots

Steps to reproduce

See #184

Expected behavior

See #184

Additional information

Including a package.json in the react preset example will pin down major versions of the packages. This should fix the issue
@apolopena apolopena added the bug Something isn't working label Jan 26, 2022
@apolopena apolopena added this to the v1.4 release 🚀 milestone Jan 26, 2022
@apolopena apolopena self-assigned this Jan 26, 2022
This was referenced Jan 26, 2022
Closed
Closed
apolopena added a commit that referenced this issue Jan 27, 2022
@apolopena
🤖 TEST: #185
5198828
apolopena added a commit that referenced this issue Jan 27, 2022
@apolopena
🤖 TEST: #185
198c934
apolopena added a commit that referenced this issue Jan 27, 2022
@apolopena
🐛 FIX: #185
5b5dec1
@apolopena
Copy link
Owner Author

Fixed, vue example works (outside of an iframe only) as well.
image

@apolopena apolopena added passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels Jan 27, 2022
@apolopena apolopena changed the title react example presets can break because they do not use their own package.json Make react example presets use their own package.json Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apolopena apolopena

Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Milestone
v1.4 release 🚀
Development

No branches or pull requests
1 participant
@apolopena