apache: rewriting the missing trailing slash when in an iframe breaks the page #134
Labels
bug
Something isn't working
passed-dev-qa
Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Describe the bug
When using SimpleBrowser or any iframe and using a gitpod/project url (ending in a directory name) without a trailing slash, the rewrite is triggered to rewrite the url with a trailing slash but
$scheme
is used so the rewrite useshttp
when the parent of the iframe ishttps
. This triggers a mixed content error and the page does not load.This issue of course does not occur when using an external browser
Screenshots
Steps to reproduce
with a default starter run the url in the simple browser with /phpmayadmin rather than /phpmyadmin/
inspect the page
You will see the mixed content errors and a white screen.
Expected behavior
trailing slash rewrites should not break the page when displayed in an iframe.
Additional information
To fix this we will use brute force by rewriting trailing slashes to use
https
instead of$scheme
.Since gitpod uses
https
this hardcoded fix will not break anything.The text was updated successfully, but these errors were encountered: