Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op: opening url paths that end in a file name gives a 404 #130

Closed
apolopena opened this issue May 10, 2021 · 1 comment
Closed

op: opening url paths that end in a file name gives a 404 #130

apolopena opened this issue May 10, 2021 · 1 comment
Assignees
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

Describe the bug

op info.php
opens in preview browser:
https://8002-rose-coyote-jfbssmea.ws-us04.gitpod.io/info.php/
The trailing slash that op appends makes the server return a 404 error
while
https://8002-rose-coyote-jfbssmea.ws-us04.gitpod.io/info.php
will display the info.php page as it should

Steps to reproduce

op index.php

Notice the url ends with a trailing slash which gives a 404 error

Expected behavior

op index.php should open the home page in the preview browser just like op with no arguments does
url paths ending in file name or a file name with query params should not display a 404 when opening with the op command

Additional information

the op command is an alias that uses .gb/bash/open-preview.sh

@apolopena apolopena added the bug Something isn't working label May 10, 2021
@apolopena apolopena self-assigned this May 10, 2021
@apolopena
Copy link
Owner Author

related to #131

apolopena added a commit that referenced this issue May 10, 2021
* 🐛 FIX: #131

* 🐛 FIX: #130 opening url paths that end in a file name gives a 404
@apolopena apolopena added in-dev-qa passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

1 participant