Docker image can build a different version of laravel that what is in VCS #112
Assignees
Comments
|
OK the refactor/fix is complete is being dev QAed as per the Expected behavior section of the bug. |
|
reverted fix. rethinking this bug. is this a bug or not? the fix made it worse. |
|
and these are the new files added when rsyncing laravel 8.* into an existing laravel 6.* project (as a --dry-run) The theory now is that all the new files from a new version 8 will not interfere wil the current old version 6 because they are new and are not tied to any of the old version 6 files. And vice versa, all old files from the old version 6 rsynced into a version 8 project will not affect version 8 because they are not tied to any of the version 8 files. Although there are some files from the new version outside of the vendor folder that would muddy up the version 6 project but they will have no other effect than making a mess. |
|
Full log when actually rsyncing (not a --dry-run) laravel 8 scaffodling into an existing laravel 6 project. Looks lke it automatically downgraded to 6 allthough there were some errors related to xdebug. the vue test page still worked and the project seems intact and not corrupt. So long story shot all these tests looks like this starter project can handle a downgrade allthough a user should never do this, it does not seem to sorrupt the laravel 6 project. Here is the full log: |
|
Looking like this is not a bug, however the user should be warned not to do this. Once a laravel version is set and project files for that version are in version control, then if upgraded to a higher version, there will be an automatic downgrade, but do it at your own risk if you must. |
|
resolved by: #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The version of Laravel is set in
composer.jsonat whatever it was when a project was pushed to the repo. If the user changes the laravel version instarter.iniand breaks cache ingitpod.Dockerfilethen the docker image will build laravel scaffolding at a different version than what the project in version control uses.Steps to reproduce
See Describe the bug section
Expected behavior
Not sure. This may not be a bug besides maybe needed updated log messages
Additional information
Laravel files from the docker image are rsynced over to the project in version control so only newer files will overwrite existing file so in theory if there are no new or modified files then there actaully is no real bug.
The only thing to do here would be to notify the user in the init summary log that there was a mismatch by design and nothing was affected.
UPDATE:
There are file changes, allthough they are all additions and not overwrites we should not assume this will alawys be the case and even if we did we would still have a mismash of files that is not helpful.
running a diff of the new (or overwritten) files between Laravel 7.* and laravel 8.*
rsync -rlptgoDi --ignore-existing --dry-run test1/ test3/ | egrep '^>'shows:So the rsync needs to not happen at all if scaffolding is already in VCS.
The text was updated successfully, but these errors were encountered: