Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lint-starter has no success message #100

Closed
apolopena opened this issue Apr 11, 2021 · 1 comment
Closed

lint-starter has no success message #100

apolopena opened this issue Apr 11, 2021 · 1 comment
Assignees
@apolopena
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

apolopena commented Apr 11, 2021 •
edited
Loading

Describe the bug

When running a shellcheck check on the starter scripts using the alias lint-starter, success if silent. This feels like maybe the check never happened.

Steps to reproduce

In a fresh workspace from this starter, run: lint-starter

If there are shellcheck warnings, there is no success message.

Expected behavior

There should be a success message when all the starter scripts pass the shellcheck.

Additional information

Its a bit noisy to show all the files checked. At a minimum just show the total number of files checked.
@apolopena apolopena added the bug Something isn't working label Apr 11, 2021
@apolopena apolopena self-assigned this Apr 11, 2021
apolopena added a commit that referenced this issue Apr 11, 2021
@apolopena
🐛 FIX: #100 lint-starter-scripts has no success message
e51af72
@apolopena apolopena added in-dev-qa passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-dev-qa labels Apr 11, 2021
@apolopena apolopena changed the title lint-starter-scripts has no success message lint-starter has no success message Apr 26, 2021
@apolopena
Copy link
Owner Author

Added -V and --verbose which will output a list of all the files checked.

@apolopena apolopena mentioned this issue Apr 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@apolopena apolopena

Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@apolopena