Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make MySql graceful when using gitpod/workspace-mysql on the first run #1

Closed
apolopena opened this issue Jan 27, 2021 · 0 comments
Closed
Assignees
Labels
bug Something isn't working fixed Bug has been fixed gitpod-config Related to gitpod configuration (bash scripts etc...) Needs Official QA Dev QA is not always enough, this could use extra eyes on it. passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@apolopena
Copy link
Owner

The MySql Daemon has a long initialization time and, that process is asynchronous and blocks whatever terminal it hijacks. This results in a two fold issue:

  1. The timing of init and command tasks in .gitpod.yml becomes inconsistant.
  2. The long wait time without a user message is a bad user experience as the workspace appears to be broken since some tasks freeze and other run out of sync due to the asynchronous blocking nature of mysqld.

*All of this can mostly be fixed by waiting for the MySql port (3306) to be open and notifying the user accordingly.

Fixes required:

    • Add a MySql initialization message with a spinner and display it wherever the user can see it (i.e not in a tab an unfocused tab). This message should only display when MySql is initializing which will be on the first run of the workspace only.
    • Refactor the .gitpod.yml tasks to account for mysqld initialization throwing off the order of when tasks run
@apolopena apolopena mentioned this issue Jan 27, 2021
@apolopena apolopena added bug Something isn't working fixed Bug has been fixed labels Jan 28, 2021
@apolopena apolopena self-assigned this Feb 4, 2021
@apolopena apolopena added Needs Official QA Dev QA is not always enough, this could use extra eyes on it. passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main gitpod-config Related to gitpod configuration (bash scripts etc...) labels Feb 4, 2021
apolopena pushed a commit that referenced this issue Dec 17, 2021
Fix the Issues #145, #147, #149, #150, #151, #152 and #153
Change xdebug.so loading to support ioncube.so loading order
Add ioncube support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed Bug has been fixed gitpod-config Related to gitpod configuration (bash scripts etc...) Needs Official QA Dev QA is not always enough, this could use extra eyes on it. passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

1 participant