Add updated router config #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on config changes in the latest `0.1.0-preview.4` release. The install script doesn't work well on OSX so rather than debugging that I'm gonna try running it from the PR machinery.
Thanks descriptive error messages!
Merged
|
@benweatherman Could you please create an issue to explain the error you had with the install script ? It will be helpful for us to follow and fix it. Thanks a lot |
|
@bnjjj will do! It seems like it's this issue #26 that was reverted in https://github.com/apollographql/supergraph-demo-fed2/pull/89/files#diff-b53ba76f4db01f4495aed4b2c95216a1370c0cca6ddc3a86f9440235752fa009L1 (maybe unintentionally? Having just 1 Dockerfile that pulls from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on config changes in the latest
0.1.0-preview.4release