Skip to content
This repository has been archived by the owner on Apr 14, 2023. It is now read-only.

Inline sources contents in source map files #513

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

alexkirsz
Copy link
Contributor

Changes proposed in this pull request:

  • Inline sources contents in source map files.

The current behavior is for .map files to refer to the source file. The issue is that the src directory is not part of the NPM package, which makes this package's source maps useless as they point to non-existent files. This causes a lot of warnings with source-map-loader.

This proposed change makes it so the content of source files gets inlined in the .map files, so there is no actual need to read the source files.

Another way to do this would be to bundle the src directory within the NPM package.

@apollo-cla
Copy link

@alexkirsz: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@DanielMSchmidt DanielMSchmidt mentioned this pull request May 7, 2019
4 tasks
@MrTibbles
Copy link

+1 to this getting merged.

@MrTibbles
Copy link

This is a better solution than #560 IMO

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexkirsz!

@hwillson hwillson merged commit 3587bf4 into apollographql:master Aug 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants