This repository has been archived by the owner on Apr 14, 2023. It is now read-only.
add optional payload to ACK #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattkrick: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
all tests pass locally, gonna close & reopen until tests complete under the 2000ms limit... |
baconz
pushed a commit
to PhiloInc/subscriptions-transport-ws
that referenced
this pull request
Apr 24, 2018
* micro is only supported in node 6 or greater * update dependencies * working Graphiql Server * updated changelog * fix linting errors * adding micro to test suite * added micro example
hwillson
approved these changes
Aug 12, 2020
There was a problem hiding this comment.
Great idea @mattkrick, thanks for this (and sorry for the long delay here!).
|
@mattkrick How do you send a payload from the server on ACK? Is there any way via the public API? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, it's nice to send a payload with an ACK.
A good example might be a JWT, in case the one the client is using is about to expire.
Another example might be the app version, which allows you to upgrade the client without requiring a refresh (this pairs nicely with the built-in reconnect logic).
I think you guys were thinking about doing this, too, because I noticed a payload field for ACKs already exists in the tests: https://github.com/apollographql/subscriptions-transport-ws/blob/master/src/test/tests.ts#L282