INIT_FAIL message appears to not be properly formatted

[hmaurer]

Hello,

I am completely new to this project so this may just be the fruit of my incompetence, but it would appear that the SubscriptionClient expect an INIT_FAIL message to contain a payload field, c.f.

subscriptions-transport-ws/src/client.ts

Line 287 in 7dba040

this.connectionCallback(parsedMessage.payload.error);

.

However, it seems that the server sets the error property directly on the message and not under a payload field, c.f.

subscriptions-transport-ws/src/server.ts

Line 161 in 7dba040

return {

This lead to an error when I tried to use connectionCallback.

Furthermore, upon rejection of the connection and if connectionCallback was not specified (to avoid the error), the client kept trying to reconnect without any backoff delay or limit on the number of reconnects.

[hmaurer]

#53
@Urigo you might have an idea about this! :)

[Urigo]

@hmaurer ohhhh very good catch!
it was actually caused by a few things (as you can see in the PR).
Fixed and added a test.

Thank you for that!

[hmaurer]

@Urigo The PR is quite instructive! Why was setTimeout required? (what message needs to be flushed and why?)

[Urigo]

@hmaurer

subscriptions-transport-ws/src/server.ts

Lines 299 to 300 in fd0fcac

	// We are using setTimeout because we want the message to be flushed before
	// disconnecting the client

The INIT_FAIL just doesn't get to the client!