This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
AR-1689 Fix crashing chromatic builds #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinanastos
force-pushed
the
justin/fix-chromatic
branch
from
bad283d to
324d4fb
Compare
justinanastos
changed the title
cheapsteak
approved these changes
Jun 4, 2020
justinanastos
force-pushed
the
justin/fix-chromatic
branch
from
324d4fb to
ab75f82
Compare
|
|
I don't believe the issue is minification @cheapsteak . This issue is coming from |
|
🚀 PR was released in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chromatic started crashing in CI. My instincts tell me it's a memory issue since we've seen this in the past. Use a larger container class and notify node that it can use 6GB of memory instead of 4.
Resolves AR-1689
This is a stopgap solution until we update to Storybook v6 which supposedly resolves the bug causing such high memory usage storybookjs/storybook#7743. I spent an hour unsuccessfully trying to upgrade to the latest beta. This will have to hold us over.