fix(rover-client): send request body as string #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/fix-up-rover-client
branch
from
295ca37 to
4e445d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #748 - as part of #727, i separated the request body function from the actual HTTP call so that testing could be easier (don't need to add a codegen step for tests). unfortunately in doing so I converted the body to a String and kept sending it with
reqwest::ReqwestBuilder::jsonwhich attempted to serialize the string instead of just sending it through. now we usereqwest::ReqwestBuilder::bodyafter usingserde_json::to_stringwhich fixes the issue entirely.