Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected "subgraph push" to "subgraph publish" on line 270 #585

Merged
merged 3 commits into from
Jun 2, 2021

Conversation

DNature
Copy link
Contributor

@DNature DNature commented May 29, 2021

I noticed that the documentation stated that to publish a federated subgraph you have to run:

- rover subgraph push my-graph@prod --name users --schema -

whereas, the push command is not present in "Rover CLI"
The correct command is:

+ rover subgraph publish my-graph@prod --name users --schema -

replacing push with publish.

@DNature DNature requested a review from StephenBarlow as a code owner May 29, 2021 15:37
@EverlastingBugstopper EverlastingBugstopper self-requested a review June 1, 2021 14:58
Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch - thanks for the PR!

@EverlastingBugstopper EverlastingBugstopper merged commit 95de9d9 into apollographql:main Jun 2, 2021
@DNature
Copy link
Contributor Author

DNature commented Jun 3, 2021

@EverlastingBugstopper The pleasure is mine :)

@EverlastingBugstopper EverlastingBugstopper added this to the June 8 milestone Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants