-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor rover-client in pursuit of structured output #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
force-pushed
the
avery/refactor-subgraph-check
branch
2 times, most recently
from
May 21, 2021 17:25
7d7332d
to
716c278
Compare
EverlastingBugstopper
changed the title
wip: refactor subgraph check and add line numbers
wip: refactor subgraph check
May 21, 2021
EverlastingBugstopper
force-pushed
the
avery/refactor-subgraph-check
branch
3 times, most recently
from
May 25, 2021 20:08
bb864be
to
382b668
Compare
EverlastingBugstopper
force-pushed
the
avery/refactor-subgraph-check
branch
from
June 11, 2021 21:28
382b668
to
4003978
Compare
EverlastingBugstopper
changed the title
wip: refactor subgraph check
chore: refactor subgraph check
Jun 11, 2021
note to me: might want to try to do an e2e test on that |
EverlastingBugstopper
force-pushed
the
avery/refactor-subgraph-check
branch
from
June 23, 2021 15:16
086980c
to
a7d9ce3
Compare
EverlastingBugstopper
changed the title
chore: refactor subgraph check
(wip) refactor rover-client
Jun 23, 2021
EverlastingBugstopper
changed the title
(wip) refactor rover-client
[wip] refactor rover-client
Jun 23, 2021
EverlastingBugstopper
force-pushed
the
avery/refactor-subgraph-check
branch
4 times, most recently
from
June 28, 2021 20:08
68fc240
to
02a8e14
Compare
This commit does a lot of heavy lifting for the pending rebase. 1) Creates new input and output types in rover-client for subgraph check 2) Moves GitContext out of rover::utils to rover-client::utils 3) Creates error code E029 for composition errors 4) Styles cloud-composition errors like harmonizer
EverlastingBugstopper
force-pushed
the
avery/refactor-subgraph-check
branch
from
June 29, 2021 18:29
478dc88
to
8d0aabf
Compare
EverlastingBugstopper
changed the title
[wip] refactor rover-client
chore: refactor rover-client in pursuit of structured output
Jul 15, 2021
EverlastingBugstopper
force-pushed
the
avery/refactor-subgraph-check
branch
from
July 15, 2021 17:54
e002f37
to
a16f4f7
Compare
lrlna
approved these changes
Jul 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a feat! This is coming together nicely. Really really into the structure of rover-client now!
EverlastingBugstopper
added a commit
that referenced
this pull request
Aug 5, 2021
EverlastingBugstopper
added a commit
that referenced
this pull request
Aug 5, 2021
…557)" This reverts structured output so we can cut a patch release for v0.1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
rover-client
into a more principled library that could be consumed by external applications. The main takeaway here is: no more codegen types in rover-client's api! everything has its own type now, there is an input and an output struct with stronger types, shared types are defined inrover-client
and most haveFromStr
implementations that are now used directly instructopt
, and we do not re-export any auto-generated types which means we will be able to swap out our graphql clients at will without worrying about breaking changes.This lays the ground work for structured output, I will have a follow-up PR to add a
--json
flag that should be able to utilize all of the work that's gone into this refactor and will make consuming that JSON much easier and more consistent than if we had tried this prior to the refactor.Additionally, I've started printing out the error codes associated with composition errors, just like
rover supergraph compose
does, which fixes #508.