fix: removes unwrap from is_federated query #549
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #548 by removing the
.unwrap
call in theis_federated
run that occurs if anything goes wrong with the query (for instance, mistyping your graph name).This PR includes a few other refactors:
is_federated
check if the--convert
flag is passed tosubgraph publish
, removing the extra network hopis_federated
query directly in therover_client::query
modules that need them, instead of inrover
code.RoverClientError::ExpectedFederatedGraph
directly fromrover_client
instead of constructing the error manually inrover
--convert
😄.ok_or
Also fixes #550