Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup: E028 wording #531

Merged
merged 1 commit into from
May 11, 2021
Merged

fixup: E028 wording #531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/rover-client/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ pub enum RoverClientError {
if let Some(url) = .url {
url.to_string()
} else {
"Unknown URL".to_string()
"unknown URL".to_string()
}
)]
CouldNotConnect {
Expand Down
4 changes: 2 additions & 2 deletions docs/source/errors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,8 +229,8 @@ To resolve this error, inspect the printed errors and correct the subgraph schem

### E028

This error occurs when a connection could not be established with to an introspection endpoint.
This error occurs when Rover could not connect to an HTTP endpoint.

To resolve this problem, make sure the endpoint URL is correct. You may wish to run the command again with `--log=debug`.
If you encountered this error while running introspection, you'll want to make sure that you typed the endpoint correctly, your Internet connection is stable, and that your server is responding to requests. You may wish to run the command again with `--log=debug`.


4 changes: 2 additions & 2 deletions src/error/metadata/codes/E028.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
This error occurs when a connection could not be established with to an introspection endpoint.
This error occurs when Rover could not connect to an HTTP endpoint.

To resolve this problem, make sure the endpoint URL is correct. You may wish to run the command again with `--log=debug`.
If you encountered this error while running introspection, you'll want to make sure that you typed the endpoint correctly, your Internet connection is stable, and that your server is responding to requests. You may wish to run the command again with `--log=debug`.
2 changes: 1 addition & 1 deletion src/error/metadata/suggestion.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ impl Display for Suggestion {
)
}
Suggestion::Adhoc(msg) => msg.to_string(),
Suggestion::CheckServerConnection => "Make sure the endpoint accepting connections is spelled correctly".to_string(),
Suggestion::CheckServerConnection => "Make sure the endpoint is accepting connections and is spelled correctly".to_string(),
Suggestion::ConvertGraphToSubgraph => "If you are sure you want to convert a non-federated graph to a subgraph, you can re-run the same command with a `--convert` flag.".to_string(),


Expand Down