Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(whoami): $APOLLO_KEY works with no default profile #516

Merged
merged 1 commit into from
May 6, 2021

Conversation

EverlastingBugstopper
Copy link
Contributor

fixes #514 by removing a direct invocation of Profile::load and using the correct Profile::get_credential function, and making Profile::load a private function.

I also removed a redundant config parameter, StudioClientConfig wraps houston's config so just using that directly should be more efficient.

@EverlastingBugstopper EverlastingBugstopper merged commit fbdb753 into main May 6, 2021
@EverlastingBugstopper EverlastingBugstopper deleted the avery/whoami-env-var branch May 6, 2021 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix 🩹 fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Authentication with $APOLLO_KEY doesn't work if there is no default profile
2 participants