chore: more efficient API key load #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
EverlastingBugstopper
force-pushed
the
avery/refactor-profile-load
branch
2 times, most recently
from
88a5134 to
605506c
Compare
EverlastingBugstopper
force-pushed
the
avery/refactor-profile-load
branch
from
605506c to
210d4e6
Compare
JakeDawkins
approved these changes
Apr 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change the behavior of any of Rover's command surface, it just makes loading API keys a bit more efficient.
Rather than calling
Profile::listevery time we want to load a single profile just so we can have a better error message, let's do the minimal amount of work to find out if no profiles have yet to be created.