Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(installer): graceful fallback to monochromic output when tput is unavailable #372

Merged
merged 3 commits into from
Mar 26, 2021

Conversation

abernix
Copy link
Member

@abernix abernix commented Mar 26, 2021

The tput command allows easier ANSI output using named values in rather than control characters.

While we could just use control characters and maintain colored output in the absence of tput, it's probably also reasonable to gracefully fall back to monochromatic output.

Fixes #371

abernix added 2 commits March 26, 2021 13:41
…ilable

The `tput` command allows easier ANSI output using named values in rather than control characters.

While we could just use control characters and maintain colored output in the absence of `tput`, it's
probably also reasonable to gracefully fall back to monochromatic output.
Copy link
Member

@lrlna lrlna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@abernix abernix marked this pull request as ready for review March 26, 2021 15:40
@abernix abernix requested a review from JakeDawkins as a code owner March 26, 2021 15:40
@abernix abernix merged commit 62f7bb7 into main Mar 26, 2021
@abernix abernix deleted the abernix/install-without-tput branch March 26, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

installer script fails when tput is unavailable
3 participants