chore: address new clippy 0.1.51 warnings #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
EverlastingBugstopper
changed the title
EverlastingBugstopper
force-pushed
the
avery/fix-clippy
branch
from
42fbc7a to
3001259
Compare
JakeDawkins
approved these changes
Mar 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new clippy update enforces rusty naming conventions and disallows capitalizing acronyms in enum variants/struct names. we had to ignore those clippy warnings in our
rover-client/querymodule because all of that stuff is autogenerated and there's nothing we can do.also wanted us to implement
Frominstead ofIntoforGitContextsinceFromgives youIntofor free while that is not the case the other way around.none of this changes any behavior.