feat: enforce all Paths to be valid Unicode #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the `camino` dependency across the codebase, ensuring that all Paths are valid UTF-8, making them much easier to work with, and be confident that invalid UTF-8 will not muck up our plans.
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
EverlastingBugstopper
force-pushed
the
avery/brand-new-car
branch
3 times, most recently
from
95f3b53 to
d137569
Compare
EverlastingBugstopper
force-pushed
the
avery/brand-new-car
branch
from
d137569 to
61f8e79
Compare
EverlastingBugstopper
added
the
feature 🎉
lrlna
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
caminodependency across the codebase, ensuring that all Paths are valid UTF-8, making them much easier to work with, and be confident that invalid UTF-8 will not muck up our plans.It does change the API surface of quite a few of our subcrates, which maybe we don't want to do! I'm open to hearing that this is not something we should be doing, but it feels valuable to me to be confident when doing IO.
I've opened this issue to see if we can't get a nice
try_fromthat returns a real error instead of thefrom_path_bufcombined withmap_errwe're currently using.