Bgs 153/nik second refinement #2359
Conversation
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: b555431a8a64d8b04f621147 |
| //}) | ||
| .map_err(|err| { | ||
| match err { | ||
| GraphQLServiceError::InvalidCredentials() => { | ||
| RoverClientError::PermissionError { | ||
| msg: "attempting to fetch subgraphs".to_string(), | ||
| } | ||
| } | ||
| _ => { | ||
| RoverClientError::Service { | ||
| source: Box::new(err), | ||
| endpoint_kind: EndpointKind::ApolloStudio, | ||
| } | ||
| } | ||
| } | ||
| }) |
There was a problem hiding this comment.
I think this came out all right. This maps the GraphQLServiceError to a RoverClientError of the correct flavor. I didn't cause this PermissionError to track source, which seems like a good idea to implement (but later).
| match RoverClientError::from(err) { | ||
| RoverClientError::PermissionError { msg } => { | ||
| LoadRemoteSubgraphsError::FetchRemoteSubgraphsAuthError(Box::new(err)) | ||
| }, | ||
| _ => { LoadRemoteSubgraphsError::FetchRemoteSubgraphsError(Box::new(err)) }, | ||
| } |
There was a problem hiding this comment.
I'm back in the same dang hole here. Even though this appears to me to literally be a RoverClientError (as that is the response type from the adjusted method in FetchAllSubgraphsService), here we don't know that, and I need some way to negotiate the type conversion. I banged my shins on writing a From in the error file, but didn't get anything working over there.
Appreciate any feedback or pointers, even if it's "This is all wrong" :)
| //the trait bound `rover_client::RoverClientError: From<<S as MakeService<(), FetchRemoteSubgraphsRequest>>::Error>` is not satisfied | ||
| //the trait `From<<S as MakeService<(), FetchRemoteSubgraphsRequest>>::Error>` is not implemented for `rover_client::RoverClientError` | ||
| //impl From<<S as MakeService<(), FetchRemoteSubgraphsRequest>>::Error> for RoverClientError { | ||
| //} | ||
|
|
There was a problem hiding this comment.
This commented section is referenced below; a rough start to attempting to impl a From trait for the pattern match I'm working on.
No description provided.