Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

persisted-queries: remove "preview" from help text #1756

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

glasser
Copy link
Member

@glasser glasser commented Sep 27, 2023

(To be merged and released when the feature enters General Availability.)

Copy link
Contributor

@EverlastingBugstopper EverlastingBugstopper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking forward to it!

@glasser glasser merged commit 981e9b8 into main Oct 4, 2023
@glasser glasser deleted the glasser/pq-not-preview branch October 4, 2023 17:42
@glasser
Copy link
Member Author

glasser commented Oct 4, 2023

(To be released when @EverlastingBugstopper is working.)

@EverlastingBugstopper EverlastingBugstopper added this to the vNext milestone Oct 5, 2023
@EverlastingBugstopper EverlastingBugstopper added the feature 🎉 new commands, flags, functionality, and improved error messages label Oct 5, 2023
EverlastingBugstopper added a commit that referenced this pull request Oct 5, 2023
# [0.20.0] - 2023-10-05

## 🚀 Features

- **Persisted Queries is now GA - @glasser, #1756**

The `rover persisted-queries publish` command is now out of the public
preview phase and has entered general availability. Check out [the
documentation](https://www.apollographql.com/docs/graphos/operations/persisted-queries)
for this enterprise feature.

## 🐛 Fixes

- **Better message for a subgraph published with no changes - @bonnici,
#1757**

`rover subgraph publish` now logs a message to `stdout` when a subgraph
was published and there were no changes to the schema.

- **Don't log username/password if `APOLLO_ROVER_DOWNLOAD_HOST` includes
authentication in the URL - @EverlastingBugstopper, #1758**

Previously, when using the `APOLLO_ROVER_DOWNLOAD_HOST` environment
variable to override the download location of a plugin binary, Rover
would log the entire URL to stdout, potentially leaking username and
password authentication details if they were included in the URL. Now,
Rover strips that information from the URLs before printing the download
location. If Rover is not able to strip that information (likely due to
an invalid URL), then it doesn't try to print the sanitized URL at all.

## 📚 Documentation

- **Improve wording of persisted queries documentation - @Meschreiber,
#1760**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants