chore: Use lychee as a link checker. #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptondereau
force-pushed
the
chore/change-link-checker-xtask
branch
from
43378c4 to
523523a
Compare
|
@EverlastingBugstopper lychee seems to find less links than the previous tool (see Lint action). |
ptondereau
force-pushed
the
chore/change-link-checker-xtask
branch
2 times, most recently
from
09872c7 to
3051361
Compare
|
@EverlastingBugstopper found out that some links are deduplicated and that's why there are fewer links to check. Before: After: |
ptondereau
changed the title
ptondereau
requested review from
EverlastingBugstopper and
lrlna
as code owners
Yes, I've forgotten to remove |
ptondereau
force-pushed
the
chore/change-link-checker-xtask
branch
from
22f31de to
ca9499d
Compare
|
OK and one more thing. Can we collect all failures into a Vec and display them at the bottom, grouped up together? |
ptondereau
force-pushed
the
chore/change-link-checker-xtask
branch
from
f6371c5 to
87d6f29
Compare
It was on my final_V2_real_final todo list haha I have to mention that due to the |
|
hmmm... i wonder if that might have been a transitive CI error? can you try removing it and pushing once more? it may have just been a bit flaky. if it still fails we can keep it around for sure 👍🏼 |
|
boo! hhooonesstlly look. we don't even run lints in windows in CI. want to just nest the link checker in a you can then add lychee-lib as an optional dependency that only comes in when the OS isn't windows i think, something like: more docs on this here: https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#platform-specific-dependencies you can then have two separate functions, one for |
ptondereau
force-pushed
the
chore/change-link-checker-xtask
branch
3 times, most recently
from
f5781b4 to
15055c3
Compare
ptondereau
force-pushed
the
chore/change-link-checker-xtask
branch
from
15055c3 to
27bcd0a
Compare
I decided to exclude only Windows and kept Unix + macOS. Should I update the contribution documentation too? |
|
nah - i don't think so! this works great 👍👍 |
ptondereau
requested review from
EverlastingBugstopper
and removed request for
lrlna
|
@EverlastingBugstopper I think CircleCI's last build crashed. Do you mind rerunning, please? |
|
CI passing, merging now 😄 |
Merged
EverlastingBugstopper
added a commit
that referenced
this pull request
Nov 14, 2022
# [0.10.0] - 2022-11-10 > Important: 1 potentially breaking change below, indicated by **❗ BREAKING ❗** ## ❗ BREAKING ❗ - **Fix implementation of `--header` argument - @EverlastingBugstopper, #1369 fixes #1365** This change tightens up usage of the `--header` argument used for `introspect` commands by disallowing previously valid (but undocumented) usage like this: `--header "Header-1: value" "Header-2: value"`. After this change, you _must_ conform to what we have in the documentation, which indicates separate instances of the `--header` argument for each header, like so: `--header "Header-1: value" --header "Header-2: value"`. ## 🚀 Features - **Provide prebuilt binaries for ARM devices - @EverlastingBugstopper, #1356 fixes #582** As of this release, [`rover.apollo.dev`](https://rover.apollo.dev) delivers prebuilt binaries from our GitHub release for ARM devices. Most notably this means that Docker on M1 devices should work out of the box. You should be able to replace any custom builds in your tooling pipeline with a call to the [official curl installer](https://www.apollographql.com/docs/rover/getting-started/#linux--macos-installer). - **Report downstream check task results - @sachindshinde, #1385** When running `rover subgraph check` commands, if the proposed schema would cause downstream failures (i.e. with contracts), those failures are now reported in the check response. - **Faster `rover supergraph compose` - @EverlastingBugstopper, #1392 fixes #992** Rover now resolves all subgraph schemas in parallel when running `rover supergraph compose` on a `supergraph.yaml` file. This should improve the speed to compose large supergraphs significantly. This change also drastically improves error handling by reporting _all_ issues with resolving subgraph schemas (and informing you which schema(s) failed to resolve) rather than exiting on the first failed schema resolution. - **Add `--polling-interval` to `rover dev` - @patrick91, #1377 fixes #1221** You can now set `--polling-interval` when running `rover dev` to change the frequency of introspection poll requests for subgraphs that don't provide the schema from the file system with the `--schema` argument. - **Adds `--skip-update-check` to skip the once-per-day update check - @Tsing, #1396 fixes #1394** Once per day, Rover checks if there is a new version available for update and notifies the user if there is. There is now a flag you can pass to disable this check: `--skip-update-check`. - **Respect the `NO_COLOR` environment variable - @chnn, #1360** `rover` will not use color in any output when executed with the `NO_COLOR` environment variable set to `true`. ## 🛠 Maintenance - **Updates from clap v3 to clap v4 - @EverlatingBugstopper, #1404 fixes #1400** This release updated the command line argument parsing library to major version 4. There should be no noticeable compatibility issues with this update, only lighter binaries. The look and feel of the main `rover --help` output has changed to a neutral color palette along with this change. - **Updates Rust to 1.65.0 - @EverlastingBugstopper, #1399** - **Updates node.js to v18 - @renovate, #1389** - **Updates node dev-dependencies - @renovate, #1204 and zs#1398** - **Remove dependency on the `saucer` crate - @EverlastingBugstopper, #1402** - **Updates `introspector-gadget` to 0.2.0 - @EverlastingBugstopper, #1386** - **Only cache dependencies in CI, not whole `/target` - @EverlastingBugstopper, #1387** - **Use `engine@main` instead of `engine@current` to fetch the API schema - @EverlastingBugstopper, #1368** - **Use `lychee` as a link checker instead of npm - @ptondereau, #1328 fixes #1306** We now use a Rust-based link checker to check the links in the Rover repository instead of a node-based link checker (that was much more flaky). - **Describe latest federation versions in `./latest_plugin_versions.json` - @EverlastingBugstopper, #1363** When you run `rover supergraph compose`, the latest version of composition is automatically downloaded to your machine, these latest version numbers are now stored in `./latest_plugin_versions.json` in the Rover repo. - **Rename `apollo-` headers to `apollographql-` headers - @jsegaran, #1411** - **Update npm to v9 - @renovate, #1412** ## 📚 Documentation - **Update studio algolia key to graphos - @trevorblades, #1384** - **Fix some broken links - @StephenBarlow, #1376** - **Fix a typo in the migration guide instructing the use of `check` instead of `publish` - @EverlastingBugstopper, #1364 fixes #1361**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1306