feat: adds --insecure-unmask-key to config whoami #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
added
feature 🎉
previously, running `rover config whoami` would output your entire API key to the terminal. This is not the documented behavior, and it is insecure because someone could be sharing their screen while trying to debug and accidentally leak their API key. now, `rover config whoami` will mask your API key when it prints to the terminal. you can override this behavior by passing the --insecure-unmask-key flag.
EverlastingBugstopper
force-pushed
the
avery/fixup-api-mask
branch
from
4046484 to
de4a796
Compare
✅ Deploy Preview for apollo-cli-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This was referenced Apr 5, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1023
previously, running
rover config whoamiwould output your entireAPI key to the terminal. This is not the documented behavior, and
it is insecure because someone could be sharing their screen
while trying to debug and accidentally leak their API key.
now,
rover config whoamiwill mask your API key when it printsto the terminal. you can override this behavior by passing the
--insecure-unmask-key flag.