Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link to supergraph specification on docs #687

Closed
paulpdaniels opened this issue Jul 23, 2021 · 3 comments · Fixed by #706
Closed

Broken link to supergraph specification on docs #687

paulpdaniels opened this issue Jul 23, 2021 · 3 comments · Fixed by #706
Labels
docs 📝 improvements or additions to docs on the docs site

Comments

@paulpdaniels
Copy link

Description

There is a link on https://github.com/apollographql/rover/blob/main/docs/source/supergraphs.md to the supergraph specification which appears to be dead (https://apollo-specs.github.io/core/draft/pre-0). I found the associated repo and it seems like it should now be pointing to here?
@paulpdaniels paulpdaniels added docs 📝 improvements or additions to docs on the docs site triage issues and PRs that need to be triaged labels Jul 23, 2021
@Beatrix-droid
Copy link

May I work on this?

@EverlastingBugstopper
Copy link
Contributor

@Beatrix-droid go for it!

abernix added a commit that referenced this issue Aug 3, 2021
@abernix
docs: Fix link to supergraph schemas
727b4c4 
This link was broken as it stood however rather than updating it to point
to the core schema specification, I've updated it to point to a set of definitions
of supergraph and subgraphs that lives within our Federation documentation.

Fixes #687
@abernix abernix mentioned this issue Aug 3, 2021
Merged
@abernix
Copy link
Member

abernix commented Aug 3, 2021

I've opened #706 which should close this. Feedback welcome!

@abernix abernix removed the triage issues and PRs that need to be triaged label Aug 3, 2021
EverlastingBugstopper pushed a commit that referenced this issue Aug 3, 2021
@abernix
docs: Fix link to supergraph schemas (#706)
a78c221 
This link was broken as it stood however rather than updating it to point
to the core schema specification, I've updated it to point to a set of definitions
of supergraph and subgraphs that lives within our Federation documentation.

Fixes #687
This was referenced Aug 5, 2021
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs 📝 improvements or additions to docs on the docs site
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Fix link to supergraph schemas apollographql/rover
4 participants
@abernix @paulpdaniels @EverlastingBugstopper @Beatrix-droid