-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider an alternative to "N/A" in rover subgraph list
#483
Comments
i like the "unroutable" that you mentioned in slack, but unspecified also works here |
|
+1 for |
This is true though, correct? If your URL is an empty string, we're pretty sure that the graph router will not be able to route any requests at all to that subgraph. Even though it's a technically allowed state, that subgraph truly is unroutable. I'm still OK with |
I think @EverlastingBugstopper's take is right, but I suppose there are cases (e.g., a mocked graph? Perhaps something in Workbench?) where Un-routable is too heavy/scary and unspecified is better? Curious what @ndintenfass thinks here. |
decision: unspecified |
Okay, |
This changes the text from "N/A" (which often means "not available", and somewhat sounds like we don't have access to it) to "unspecified" (which is what it is; this is what it is though represented by `null` in the DB). Closes #483
This changes the text from "N/A" (which often means "not available", and somewhat sounds like we don't have access to it) to "unspecified" (which is what it is; this is what it is though represented by `null` in the DB). Closes #483
This changes the text from "N/A" (which often means "not available", and somewhat sounds like we don't have access to it) to "unspecified" (which is what it is; this is what it is though represented by `null` in the DB). Closes #483
Description
Perhaps rather than showing that the Routing Url is "N/A" (Not available), which makes it sound like it's not available (for some transient reason), we should state that it's "Unspecified" or "Not defined"? Happy to open a PR!
rover/src/command/output.rs
Line 68 in 9110438
The text was updated successfully, but these errors were encountered: