chore: use rustls-tls-native-roots everywhere

crates/rover-client/src/blocking/client.rs

@@ -8,6 +8,14 @@ use reqwest::{
 
 use std::collections::HashMap;
 
+pub(crate) fn get_client() -> Result<ReqwestClient, ReqwestError> {
+    ReqwestClient::builder()
+        .use_rustls_tls()
+        .tls_built_in_root_certs(true)
+        .gzip(true)
+        .build()
+}
+
 /// Represents a generic GraphQL client for making http requests.
 pub struct GraphQLClient {
     client: ReqwestClient,
@@ -19,11 +27,7 @@ impl GraphQLClient {
     /// This client is used for generic GraphQL requests, such as introspection.
     pub fn new(graphql_endpoint: &str) -> Result<GraphQLClient, ReqwestError> {
         Ok(GraphQLClient {
-            client: ReqwestClient::builder()
-                .use_rustls_tls()
-                .tls_built_in_root_certs(true)
-                .gzip(true)
-                .build()?,
+            client: get_client()?,
             graphql_endpoint: graphql_endpoint.to_string(),
         })
     }

crates/rover-client/src/blocking/mod.rs

@@ -1,5 +1,6 @@
 mod client;
 mod studio_client;
 
+pub(crate) use client::get_client;
 pub use client::GraphQLClient;
 pub use studio_client::StudioClient;

crates/rover-client/src/releases.rs

@@ -1,12 +1,11 @@
-use crate::RoverClientError;
+use crate::{blocking::get_client, RoverClientError};
 use regex::Regex;
-use reqwest::blocking;
 
 const LATEST_RELEASE_URL: &str = "https://github.com/apollographql/rover/releases/latest";
 
 /// Looks up the latest release version, and returns it as a string
 pub fn get_latest_release() -> Result<String, RoverClientError> {
-    let res = blocking::Client::new().head(LATEST_RELEASE_URL).send()?;
+    let res = get_client()?.head(LATEST_RELEASE_URL).send()?;
 
     let release_url = res.url().to_string();
     let release_url_parts: Vec<&str> = release_url.split('/').collect();

crates/sputnik/Cargo.toml

@@ -8,7 +8,7 @@ edition = "2018"
 camino = "1.0"
 ci_info = { version = "0.14", features = ["serde-1"] }
 git2 = "0.13"
-reqwest = { version = "0.11", features = ["blocking"] }
+reqwest = { version = "0.11", features = ["blocking", "rustls-tls-native-roots"] }
 semver = { version = "1", features = ["serde"] }
 serde = { version = "1.0", features = ["derive"] }
 serde_json = "1.0"

crates/sputnik/src/session.rs

@@ -125,7 +125,10 @@ impl Session {
             let body = serde_json::to_string(&self)?;
             tracing::debug!("POSTing to {}", &self.reporting_info.endpoint);
             tracing::debug!("{}", body);
-            reqwest::blocking::Client::new()
+            reqwest::blocking::Client::builder()
+                .use_rustls_tls()
+                .tls_built_in_root_certs(true)
+                .build()?
                 .post(self.reporting_info.endpoint.clone())
                 .body(body)
                 .header("User-Agent", &self.reporting_info.user_agent)