Migrate histogram metrics to {f,u}64_histogram!
#6356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
|
CI performance tests
|
goto-bus-stop
commented
Nov 28, 2024
apollo-router/src/graphql/request.rs
Outdated
Comment on lines
200
to
205
| f64_histogram!( | ||
| "apollo.router.operations.batching.size", | ||
| "Number of queries contained within each query batch", | ||
| result.len() as f64, | ||
| mode = BatchingMode::BatchHttpLink.to_string() // Only supported mode right now | ||
| ); |
There was a problem hiding this comment.
Could we safely change this to u64_histogram!, or would that be a breaking change?
There was a problem hiding this comment.
I don't think it breaks anything. @BrynCooke do you know ?
goto-bus-stop
force-pushed
the
renee/ROUTER-297-histograms
branch
from
6294bac to
8b333e5
Compare
Notes: - The name of the metric used a `.` instead of `_` in `query_planning`. Is it breaking to change that? I'm not sure I understand the difference
goto-bus-stop
force-pushed
the
renee/ROUTER-297-histograms
branch
from
8b333e5 to
eed5480
Compare
This comment has been minimized.
This comment has been minimized.
bnjjj
requested changes
Dec 20, 2024
apollo-router/src/graphql/request.rs
Outdated
Comment on lines
200
to
205
| f64_histogram!( | ||
| "apollo.router.operations.batching.size", | ||
| "Number of queries contained within each query batch", | ||
| result.len() as f64, | ||
| mode = BatchingMode::BatchHttpLink.to_string() // Only supported mode right now | ||
| ); |
There was a problem hiding this comment.
I don't think it breaks anything. @BrynCooke do you know ?
bnjjj
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 2 of... 4 or 5? of a series of work to move over to our new telemetry macros, and a follow-up to #6350.
We have both a
u64_histogram!and af64_histogram!macro, but we don't have any legacy metrics usingu64. We do have one that could:apollo.router.operations.batching.size.The
tracing::info!(histogram.)syntax continues to be supported in the 1.x branch of the router.Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩